[Discover Test] TestID-69: Filtering, Test Suite: Filter actions in table field #9011
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ween loading column definition and data (opensearch-project#8928) Signed-off-by: Miki <[email protected]>
…rkspace is deleted (opensearch-project#8900) * feat: optimize recent items and filter out items whose workspace is deleted Signed-off-by: tygao <[email protected]> * Changeset file for PR opensearch-project#8900 created/updated * seperate link Signed-off-by: tygao <[email protected]> * update filter sequence Signed-off-by: tygao <[email protected]> --------- Signed-off-by: tygao <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Fixes SQL monaco monarch tokens by separating the states for single quoted and double quoted strings so that both can appear properly --------- Signed-off-by: Paul Sebastian <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
…h-project#8886) * Bump `@opensearch-project/opensearch` from 2.9.0 to 2.13.0 Signed-off-by: Miki <[email protected]> * Changeset file for PR opensearch-project#8886 created/updated --------- Signed-off-by: Miki <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
…s link (opensearch-project#8919) * page_references_insecure Signed-off-by: Qxisylolo <[email protected]> * typo Signed-off-by: Qxisylolo <[email protected]> * Changeset file for PR opensearch-project#8919 created/updated * add https://numeraljs.com/ to lycheeignore Signed-off-by: Qxisylolo <[email protected]> * change https://numeraljs.com/ to http Signed-off-by: Qxisylolo <[email protected]> --------- Signed-off-by: Qxisylolo <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
…project#8920) * support search dev tools by category name Signed-off-by: Hailong Cui <[email protected]> * Changeset file for PR opensearch-project#8920 created/updated * address review comments Signed-off-by: Hailong Cui <[email protected]> --------- Signed-off-by: Hailong Cui <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
…et (opensearch-project#8888) * Isolate objects based on workspace when calling get/bulkGet Signed-off-by: yubonluo <[email protected]> * Changeset file for PR opensearch-project#8888 created/updated * add integration tests Signed-off-by: yubonluo <[email protected]> * optimize the code Signed-off-by: yubonluo <[email protected]> * optimize the code Signed-off-by: yubonluo <[email protected]> * optimize the code Signed-off-by: yubonluo <[email protected]> * optimize the function name Signed-off-by: yubonluo <[email protected]> * add data source validate Signed-off-by: yubonluo <[email protected]> * optimize the code Signed-off-by: yubonluo <[email protected]> --------- Signed-off-by: yubonluo <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
) * replace default query with current query Signed-off-by: Sean Li <[email protected]> * Changeset file for PR opensearch-project#8930 created/updated * adding unit tests Signed-off-by: Sean Li <[email protected]> --------- Signed-off-by: Sean Li <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
…ts (opensearch-project#8739) * Check if workspaces exists when creating saved objects Signed-off-by: yubonluo <[email protected]> * Changeset file for PR opensearch-project#8739 created/updated * optimize the code Signed-off-by: yubonluo <[email protected]> * fix test error Signed-off-by: yubonluo <[email protected]> * optimize the code Signed-off-by: yubonluo <[email protected]> * fix test errors Signed-off-by: yubonluo <[email protected]> * add integration tests Signed-off-by: yubonluo <[email protected]> --------- Signed-off-by: yubonluo <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
…nsearch-project#8992) Signed-off-by: Joshua Li <[email protected]>
* Update Cypress to v12 (opensearch-project#8926) * Update cypress to v12 Signed-off-by: Daniel Rowe <[email protected]> * Add required e2e.js Signed-off-by: Daniel Rowe <[email protected]> * Changeset file for PR opensearch-project#8926 created/updated * Update license header Signed-off-by: Daniel Rowe <[email protected]> * Update license in e2e.js Signed-off-by: Daniel Rowe <[email protected]> --------- Signed-off-by: Daniel Rowe <[email protected]> Signed-off-by: Daniel Rowe <[email protected]> Co-authored-by: Daniel Rowe <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> * fix: support imports without extensions in cypress webpack build (opensearch-project#8993) * fix: support imports without extensions in cypress webpack build Signed-off-by: Daniel Rowe <[email protected]> * Changeset file for PR opensearch-project#8993 created/updated * use typescript config Signed-off-by: Daniel Rowe <[email protected]> * fix lint Signed-off-by: Daniel Rowe <[email protected]> * disable new test isolation feature This isolation was causing regressions Signed-off-by: Daniel Rowe <[email protected]> --------- Signed-off-by: Daniel Rowe <[email protected]> Signed-off-by: Daniel Rowe <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> --------- Signed-off-by: Daniel Rowe <[email protected]> Signed-off-by: Daniel Rowe <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
…ensearch-project#8876) * [Query enhancements] use status 503 if opensearch throws 500 Signed-off-by: Joshua Li <[email protected]> * update unit tests Signed-off-by: Joshua Li <[email protected]> --------- Signed-off-by: Joshua Li <[email protected]>
… is almost complete, just working on removing the filter.
… into testid-69-filtering
Reformat for TS.
Refactor to match OSD-functional-tests-layout.
ArgusLi
requested review from
ananzh,
kavilla,
AMoo-Miki,
ashwin-pc,
joshuarrrr,
abbyhu2000,
zengyan-amazon,
zhongnansu,
manasvinibs and
ZilongX
as code owners
ArgusLi
requested review from
ruanyl,
BionIT,
xinruiba,
zhyuanqi,
mengweieric,
LDrago27,
virajsanghvi,
sejli,
joshuali925 and
huyaboo
as code owners
❌ Invalid Prefix For Manual Changeset CreationInvalid description prefix. Found "test Add a test for the Filter actions in the table field in the Discover Page.". Only "skip" entry option is permitted for manual commit of changeset files. If you were trying to skip the changelog entry, please use the "skip" entry option in the ##Changelog section of your PR description. |
github-actions
bot
added
failed changeset
Skip-Changelog
…9003) * clear the attribute of error objects Signed-off-by: yubonluo <[email protected]> * Changeset file for PR opensearch-project#9003 created/updated * Changeset file for PR opensearch-project#9003 deleted --------- Signed-off-by: yubonluo <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
* bump url to 0.11.4 Signed-off-by: Joshua Li <[email protected]> * Changeset file for PR opensearch-project#8611 created/updated --------- Signed-off-by: Joshua Li <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
d-rowe
reviewed
Dec 5, 2024
| describe('index pattern dataset', () => { | ||
| // filter actions should exist for DQL | ||
| it('DQL', () => { | ||
| cy.selectIndexPatternDataset('DQL'); |
There was a problem hiding this comment.
Thanks for fully utilizing utils here across this test file.
cypress.config.ts
Outdated
| specPattern: 'cypress/integration/**/*_spec.{js,jsx,ts,tsx}', | ||
| testIsolation: false, | ||
| testIsolation: true, |
There was a problem hiding this comment.
As a part of the Cypress I saw a couple existing tests that are not written in an isolated manner, which caused failures when I enabled this initially.
If all our tests pass with isolation on now, that's great! Let's just check the cypress tests on this PR when they run to verify that there are no new failures due to this enablement
There was a problem hiding this comment.
I don't think that the other tests are running, I will revert the testIsolation to false and change my test to reflect the lack of test isolation.
There was a problem hiding this comment.
Addressed in newest commit.
cypress/support/e2e.js
Outdated
Comment on lines
13
to
16
| Cypress.on('uncaught:exception', (_err) => { | ||
| // returning false here prevents Cypress from failing the test | ||
| return false; | ||
| }); |
There was a problem hiding this comment.
Makes sense, there are some uncaught errors that we do want to gracefully ignore. That being said, I feel there are times when bubbling up an uncaught exception would be really useful. For example, if a page fails to render it'd be nice to see the exception in the runner rather than having to run locally and dig for it.
Can we be a bit more selective here and only swallow the error you were seeing needed to be handled gracefully?
Ex.
const resizeObserverLoopErr = /^[^(ResizeObserver loop limit exceeded)]/;
Cypress.on('uncaught:exception', (err) => {
/* returning false here prevents Cypress from failing the test */
if (resizeObserverLoopErr.test(err.message)) {
return false;
}
});
There was a problem hiding this comment.
Sounds good. I added this as I was getting a specific navigation error. Keeping the ignore selective makes a lot of sense to me.
There was a problem hiding this comment.
Addressed in newest commit.
…project#8935) Signed-off-by: Joshua Li <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Change testIsolation to be false, ignore uncaught errors to be more selective.
Search bar objects that are non-page specific have been kept as commands.
…le-field Signed-off-by: Argus Li <[email protected]>
ananzh
added
the
discover_2.0-test
|
Superseded by #9119 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds a cypress test for the Discover Page.
This PR completes the "Filter actions in table field" test suite in TestID-69: Filtering. There is still the "Filter actions in expanded table" Test Suite to complete for that ticket.
Changelog
Check List
yarn test:jestyarn test:jest_integration